Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure non-nil sessionId #1814

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Ensure non-nil sessionId #1814

merged 5 commits into from
Dec 16, 2024

Conversation

SystemKeeper
Copy link
Collaborator

Fixed in this PR:

  • SessionId is an optional, we only rely on the HTTP status code currently
  • For creating a room object, we only rely on the listable capability currently
  • In ChatViewController we just ensure that there's a NCRoom object, not, that it is the correct one

(The last 2 fixes are fixing basically the same thing, but I think we should be explicit here)

@SystemKeeper SystemKeeper marked this pull request as draft October 7, 2024 21:47
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper SystemKeeper marked this pull request as ready for review December 15, 2024 14:12
@SystemKeeper
Copy link
Collaborator Author

Most of the observed crashes that were observed with a null-token seem to have gone, which makes we wonder if they were really a bug in our (talk/talk-ios) codebase...
Therefore I think we can remove the fatalError experiment again (didn't yield any results anyway). Still I would like to add the safe-guards, just in case.

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@Ivansss Ivansss merged commit f3f79c0 into master Dec 16, 2024
11 checks passed
@Ivansss Ivansss deleted the ensure-sessionid branch December 16, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants