feat(PushNotifications): Allow to test push notifications #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
There was a problem hiding this comment.
Tested and works nicely.
One thing I noticed, there's no indication that the test request is running. So when the server is a bit slow, or the internet connection a bit weak, you might press the test button multiple times. Should we disable the test button (maybe with an activity indicator) until we received an API response?
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
|
Added activity indicator and disable user interaction in cell while test is running |
…ults Signed-off-by: Ivan Sein <ivan@nextcloud.com>
SystemKeeper
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option in diagnostics view to test push notifications:
Show results after the test and allow to copy them: