Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for displaying context chats #1918

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Fixes for displaying context chats #1918

merged 5 commits into from
Dec 16, 2024

Conversation

SystemKeeper
Copy link
Collaborator


  • The longPressGesture was disabled on viewDidLoad only. Rotating the screen would call setTitleView which then again had an enabled longPressGesture.
  • We reset the title view when the view transitions, but it's actually enough (and more smooth), to do so when the traitCollection changes.
  • Removed unused capture that wasn't used in the methods body
  • Added a close button to ContextChatViewController when being displayed from the media viewer.
  • Noticed that we still use Cancel when displaying the context from the shared items tab -> changed to Close.

@SystemKeeper
fix(contextChat): Ensure longPressGesture is disabled
8aaad3e 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
fix(titleview): Reset on trait changes
c656538 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
fix(mediaViewer): Remove unused capture
271182c 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
fix(mediaView): Show close button on context
8aedd85 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
fix(sharedItems): "Close" instead of "Cancel"
71b4548 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@Ivansss Ivansss merged commit b5adb98 into master Dec 16, 2024
11 checks passed
@Ivansss Ivansss deleted the follow-up-to-1916 branch December 16, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansss Ivansss Ivansss approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SystemKeeper @Ivansss