Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(polls): Allow editing and deleting poll drafts #1965

Merged
merged 1 commit into from
Jan 31, 2025
Merged

feat(polls): Allow editing and deleting poll drafts #1965

merged 1 commit into from
Jan 31, 2025
+160 −20

Conversation

Ivansss
Copy link
Member

@Ivansss Ivansss commented Jan 30, 2025

IMG_E0129

@Ivansss
feat(polls): Allow editing and deleting poll drafts
b971ea5 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss Ivansss requested a review from SystemKeeper January 30, 2025 17:45
SystemKeeper
SystemKeeper approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. The only thing I find a bit confusing is that "Cancel" on edit will close the whole controller and it is not like "going back to creation". But I don't think that's a big issue.

@SystemKeeper SystemKeeper merged commit cc6f743 into master Jan 31, 2025
10 checks passed
@SystemKeeper SystemKeeper deleted the feat/noid/allow-editing-poll-drafts branch January 31, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ivansss @SystemKeeper