Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle timezone of completed, created and modified date #2638

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

raimund-schluessler
Copy link
Member

@raimund-schluessler raimund-schluessler commented Aug 5, 2024

I have no idea why, but the timezone is not correctly respected when doing

this._modified = now
this._modifiedMoment = moment(this._modified, 'YYYYMMDDTHHmmssZ')

instead of

this._modified = now
this._modifiedMoment = moment(now, 'YYYYMMDDTHHmmssZ')

So, this PR now uses the second code snippet for handling the created, modified and completed dates.

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added this to the 0.16.1 milestone Aug 5, 2024
@raimund-schluessler raimund-schluessler changed the title fix: correctly handle timezone of completed, created and modified d ate fix: correctly handle timezone of completed, created and modified date Aug 5, 2024
@raimund-schluessler raimund-schluessler merged commit 53ee70c into master Aug 5, 2024
13 of 25 checks passed
@raimund-schluessler raimund-schluessler deleted the fix/noid/dates-timezone branch August 5, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant