fix(Step): Use largest possible 32-bit int value for transition

The value used before (largest possible MySQL BIGINT value) was too big
for PHP int. Since we still support 32-bit platforms on Nextcloud, let's
stick to the largest possible 32-bit PHP integer value.

Besides, setting the value as default for `Step::version` doesn't work
as `QBMapper->insert()` doesn't recognize the `version` field as changed
in that case. So let's default to `0` again and set it using
`Step->setVersion()` later.

Signed-off-by: Jonas <jonas@freesources.org>

lib/Db/Step.php

@@ -41,13 +41,13 @@ class Step extends Entity implements JsonSerializable {
 	/*
 	 * Transition: We now use the auto-incrementing id as the version.
 	 * To ensure that new steps always have a larger version than those that
-	 * used the version field, use the largest possible value for BIGINT.
+	 * used the version field, use the largest possible 32-bit integer value.
 	 */
-	public const VERSION_STORED_IN_ID = 18446744073709551615;
+	public const VERSION_STORED_IN_ID = 2147483647;
 
 	public $id = null;
 	protected string $data = '';
-	protected int $version = self::VERSION_STORED_IN_ID;
+	protected int $version = 0;
 	protected int $sessionId = 0;
 	protected int $documentId = 0;
 

lib/Service/DocumentService.php

@@ -278,6 +278,7 @@ private function insertSteps($documentId, $sessionId, $steps, $version): int {
 			$step->setData($stepsJson);
 			$step->setSessionId($sessionId);
 			$step->setDocumentId($documentId);
+			$step->setVersion(Step::VERSION_STORED_IN_ID);
 			$step = $this->stepMapper->insert($step);
 			$newVersion = $step->getId();
 			$this->logger->debug("Adding steps to " . $documentId . ": bumping version from $stepsVersion to $newVersion");