test(cy): rely on @nextcloud/axios for requests

This greatly simplifies the handling of csrf-tokens and auth. Signed-off-by: Max <max@nextcloud.com>
nextcloud · Apr 25, 2024 · 5db6712 · 5db6712
1 parent a8c437f
commit 5db6712
Show file tree

Hide file tree

Showing 7 changed files with 144 additions and 316 deletions.
diff --git a/cypress/e2e/api/SessionApi.spec.js b/cypress/e2e/api/SessionApi.spec.js
@@ -39,7 +39,6 @@ describe('The session Api', function() {
 
 	beforeEach(function() {
 		cy.login(user)
-		cy.prepareSessionApi()
 	})
 
 	describe('open the session', function() {
@@ -223,7 +222,6 @@ describe('The session Api', function() {
 				})
 				.then(() => cy.clearCookies())
 				.then(() => {
-					cy.prepareSessionApi()
 					return cy.createTextSession(undefined, { filePath: '', shareToken })
 						.then(con => {
 							connection = con
@@ -247,7 +245,6 @@ describe('The session Api', function() {
 				.should('be.at.least', 1)
 			cy.save(connection, { version: 1, autosaveContent: '# Heading 1', manualSave: true })
 			cy.login(user)
-			cy.prepareSessionApi()
 			cy.downloadFile('saves.md')
 				.its('data')
 				.should('eql', '# Heading 1')
@@ -290,7 +287,6 @@ describe('The session Api', function() {
 				cy.log(token)
 				shareToken = token
 				cy.clearCookies()
-				cy.prepareSessionApi()
 				cy.createTextSession(undefined, { filePath: '', shareToken })
 					.then(con => {
 						connection = con

diff --git a/cypress/e2e/api/SyncServiceProvider.spec.js b/cypress/e2e/api/SyncServiceProvider.spec.js
@@ -37,7 +37,6 @@ describe('Sync service provider', function() {
 
 	beforeEach(function() {
 		cy.login(user)
-		cy.prepareSessionApi()
 		cy.uploadTestFile('test.md')
 			.then(id => {
 				fileId = id

diff --git a/cypress/e2e/api/UsersApi.spec.js b/cypress/e2e/api/UsersApi.spec.js
@@ -37,7 +37,6 @@ describe('The user mention API', function() {
 		cy.login(user)
 		cy.uploadTestFile('test.md').as('fileId')
 			.then(cy.createTextSession).as('connection')
-		cy.getRequestToken()
 	})
 
 	afterEach(function() {

diff --git a/cypress/e2e/directediting.spec.js b/cypress/e2e/directediting.spec.js
@@ -2,52 +2,6 @@ import { initUserAndFiles, randUser } from '../utils/index.js'
 
 const user = randUser()
 
-const createDirectEditingLink = (user, file) => {
-	cy.login(user)
-	return cy.request({
-		method: 'POST',
-		url: `${Cypress.env('baseUrl')}/ocs/v2.php/apps/files/api/v1/directEditing/open?format=json`,
-		form: true,
-		body: {
-			path: file,
-		},
-		auth: { user: user.userId, pass: user.password },
-		headers: {
-			'OCS-ApiRequest': 'true',
-			'Content-Type': 'application/x-www-form-urlencoded',
-		},
-	}).then(response => {
-		cy.log(response)
-		const token = response.body?.ocs?.data?.url
-		cy.log(`Created direct editing token for ${user.userId}`, token)
-		return cy.wrap(token)
-	})
-}
-
-const createDirectEditingLinkForNewFile = (user, file) => {
-	cy.login(user)
-	return cy.request({
-		method: 'POST',
-		url: `${Cypress.env('baseUrl')}/ocs/v2.php/apps/files/api/v1/directEditing/create?format=json`,
-		form: true,
-		body: {
-			path: file,
-			editorId: 'text',
-			creatorId: 'textdocument',
-		},
-		auth: { user: user.userId, pass: user.password },
-		headers: {
-			'OCS-ApiRequest': 'true',
-			'Content-Type': 'application/x-www-form-urlencoded',
-		},
-	}).then(response => {
-		cy.log(response)
-		const token = response.body?.ocs?.data?.url
-		cy.log(`Created direct editing token for ${user.userId}`, token)
-		return cy.wrap(token)
-	})
-}
-
 describe('direct editing', function() {
 
 	const visitHooks = {
@@ -66,7 +20,8 @@ describe('direct editing', function() {
 		cy.intercept({ method: 'POST', url: '**/session/*/push' }).as('push')
 		cy.intercept({ method: 'POST', url: '**/session/*/sync' }).as('sync')
 
-		createDirectEditingLink(user, 'empty.md')
+		cy.login(user)
+		cy.createDirectEditingLink('empty.txt')
 			.then((token) => {
 				cy.logout()
 				cy.visit(token, visitHooks)
@@ -94,7 +49,8 @@ describe('direct editing', function() {
 		cy.intercept({ method: 'POST', url: '**/session/*/push' }).as('push')
 		cy.intercept({ method: 'POST', url: '**/session/*/sync' }).as('sync')
 
-		createDirectEditingLinkForNewFile(user, 'newfile.md')
+		cy.login(user)
+		cy.createDirectEditingLinkForNewFile('newfile.md')
 			.then((token) => {
 				cy.logout()
 				cy.visit(token, visitHooks)
@@ -123,7 +79,8 @@ describe('direct editing', function() {
 		cy.intercept({ method: 'POST', url: '**/session/*/push' }).as('push')
 		cy.intercept({ method: 'POST', url: '**/session/*/sync' }).as('sync')
 
-		createDirectEditingLink(user, 'empty.txt')
+		cy.login(user)
+		cy.createDirectEditingLink('empty.txt')
 			.then((token) => {
 				cy.logout()
 				cy.visit(token, visitHooks)

diff --git a/cypress/e2e/propfind.spec.js b/cypress/e2e/propfind.spec.js
@@ -51,7 +51,7 @@ describe('Text PROPFIND extension ', function() {
 			cy.uploadFile('test.md', 'text/markdown', '/Readme.md')
 			cy.propfindFolder('/')
 				.should('have.property', richWorkspace, '## Hello world\n')
-			cy.removeFile('/Readme.md')
+			cy.deleteFile('/Readme.md')
 			cy.propfindFolder('/')
 				.should('have.property', richWorkspace, '')
 		})