-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling capitelized letters in keyboard shortcuts in markdown editor #2050
Comments
I checked other online editors (Notion and Google Docs) and there indeed shortcuts with capitalized characters work - but shortcuts with Shift don't (e.g. |
It hink its not about regular shift, but having caps lock activated, there both notion and google docs seem to also toggle. |
I reported the issue upstream: ueberdosis/tiptap#2426 Also did some local testing, and adding the uppercase key to the keymap for a mark (.e.g in keys({ type }) {
return {
'Mod-b': toggleMark(type),
'Mod-B': toggleMark(type),
}
} Only downside is, that key combinations with shift (Ctrl-Shift-b in this example) will be caught as well. But as written in the upstream issue, I think that's an acceptable tradeoff. |
Opened a PR upstream: ueberdosis/tiptap#2478 |
This way, key bindings 'Mod-B', 'Mod-I' and 'Mod-U' with active caps lock have the same effect as their lowercase siblings. This is supposed to be fixed in Tiptap v2 upstream: ueberdosis/tiptap#2426 ueberdosis/tiptap#2478 Fixes: #2050 Signed-off-by: Jonas <jonas@freesources.org>
This way, key bindings 'Mod-B', 'Mod-I' and 'Mod-U' with active caps lock have the same effect as their lowercase siblings. This is supposed to be fixed in Tiptap v2 upstream: ueberdosis/tiptap#2426 ueberdosis/tiptap#2478 Fixes: #2050 Signed-off-by: Jonas <jonas@freesources.org>
This way, key bindings 'Mod-B', 'Mod-I' and 'Mod-U' with active caps lock have the same effect as their lowercase siblings. This is supposed to be fixed in Tiptap v2 upstream: ueberdosis/tiptap#2426 ueberdosis/tiptap#2478 Fixes: #2050 Signed-off-by: Jonas <jonas@freesources.org>
This way, key bindings 'Mod-B', 'Mod-I' and 'Mod-U' with active caps lock have the same effect as their lowercase siblings. This is supposed to be fixed in Tiptap v2 upstream: ueberdosis/tiptap#2426 ueberdosis/tiptap#2478 Fixes: #2050 Signed-off-by: Jonas <jonas@freesources.org>
This way, key bindings 'Mod-B', 'Mod-I' and 'Mod-U' with active caps lock have the same effect as their lowercase siblings. This is supposed to be fixed in Tiptap v2 upstream: ueberdosis/tiptap#2426 ueberdosis/tiptap#2478 Fixes: #2050 Signed-off-by: Jonas <jonas@freesources.org>
How to use GitHub
Is your feature request related to a problem? Please describe.
I was working on a markdown document the other day and I was curently in caps lock mode and noticed that ctrl + B and other keyboard shortcuts do not work. When I turned caps lock off, everything was ok.
Describe the solution you'd like
Enabling keyboard shortcuts for capitalized letters, e. g. ctrl+b = ctrl+B. I am shure that it should be an easy fix and would help with being a bit more user freindly.
The text was updated successfully, but these errors were encountered: