-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo broken in collaborative editing session #4601
Labels
Comments
mejo-
added
bug
Something isn't working
0. Needs triage
bug: regression
feature: sync
high
labels
Jul 28, 2023
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Office team
Jul 28, 2023
mejo-
moved this from 🧭 Planning evaluation (don't pick)
to 📄 To do (~10 entries)
in 📝 Office team
Jul 28, 2023
This commit broke undo: 2da1f89 Probably we have to make sure to always either load |
mejo-
added a commit
that referenced
this issue
Aug 2, 2023
Instead of loading Tiptap `extension-history` in RichText.js, let's load it only in `MarkdownContentEditor.vue`. * Editor.vue loads `extension-collaboration` * MarkdownContentEditor.vue loads `extension-history` Fixes: #4601 Signed-off-by: Jonas <jonas@freesources.org>
3 tasks
github-project-automation
bot
moved this from 📄 To do (~10 entries)
to ☑️ Done
in 📝 Office team
Aug 2, 2023
backportbot-nextcloud bot
pushed a commit
that referenced
this issue
Aug 2, 2023
Instead of loading Tiptap `extension-history` in RichText.js, let's load it only in `MarkdownContentEditor.vue`. * Editor.vue loads `extension-collaboration` * MarkdownContentEditor.vue loads `extension-history` Fixes: #4601 Signed-off-by: Jonas <jonas@freesources.org>
backportbot-nextcloud bot
pushed a commit
that referenced
this issue
Aug 2, 2023
Instead of loading Tiptap `extension-history` in RichText.js, let's load it only in `MarkdownContentEditor.vue`. * Editor.vue loads `extension-collaboration` * MarkdownContentEditor.vue loads `extension-history` Fixes: #4601 Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In collaborative editing sessions with more than one client, undo doesn't work anymore. Undoing your own changes only works as long as no remote changes got applied to your document state.
In cases where undo doesn't work, instead the cursor jumps to the end of the document.
To Reproduce
Steps to reproduce the behavior:
The text was updated successfully, but these errors were encountered: