Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo broken in collaborative editing session #4601

Closed
mejo- opened this issue Jul 28, 2023 · 1 comment · Fixed by #4621
Closed

Undo broken in collaborative editing session #4601

mejo- opened this issue Jul 28, 2023 · 1 comment · Fixed by #4621

Comments

@mejo-
Copy link
Member

mejo- commented Jul 28, 2023

Describe the bug

In collaborative editing sessions with more than one client, undo doesn't work anymore. Undoing your own changes only works as long as no remote changes got applied to your document state.

In cases where undo doesn't work, instead the cursor jumps to the end of the document.

To Reproduce
Steps to reproduce the behavior:

  1. Open a document with two sessions (can be same user)
  2. Do a change in one session, use undo function, see it doing its thing
  3. Do a change in one session, do a second change in second session, try undo in first session
  4. Undo doesn't work as expected
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Jul 28, 2023
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Jul 28, 2023
@mejo-
Copy link
Member Author

mejo- commented Aug 2, 2023

This commit broke undo: 2da1f89

Probably we have to make sure to always either load extension-collaboration or extension-history.

mejo- added a commit that referenced this issue Aug 2, 2023
Instead of loading Tiptap `extension-history` in RichText.js, let's load
it only in `MarkdownContentEditor.vue`.

* Editor.vue loads `extension-collaboration`
* MarkdownContentEditor.vue loads `extension-history`

Fixes: #4601

Signed-off-by: Jonas <jonas@freesources.org>
@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 📝 Office team Aug 2, 2023
backportbot-nextcloud bot pushed a commit that referenced this issue Aug 2, 2023
Instead of loading Tiptap `extension-history` in RichText.js, let's load
it only in `MarkdownContentEditor.vue`.

* Editor.vue loads `extension-collaboration`
* MarkdownContentEditor.vue loads `extension-history`

Fixes: #4601

Signed-off-by: Jonas <jonas@freesources.org>
backportbot-nextcloud bot pushed a commit that referenced this issue Aug 2, 2023
Instead of loading Tiptap `extension-history` in RichText.js, let's load
it only in `MarkdownContentEditor.vue`.

* Editor.vue loads `extension-collaboration`
* MarkdownContentEditor.vue loads `extension-history`

Fixes: #4601

Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant