Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link preview and link bubble broken in public shares (and with reference_opengraph = false) #5520

Closed
mejo- opened this issue Mar 18, 2024 · 2 comments
Closed

Link preview and link bubble broken in public shares (and with reference_opengraph = false) #5520

mejo- opened this issue Mar 18, 2024 · 2 comments
Assignees
@mejo-
Labels
29 feedback bug Something isn't working
Milestone
Nextcloud 30

Comments

@mejo-
Copy link
Member

mejo- commented Mar 18, 2024

Describe the bug
In public shares we currently don't load previews (or other reference widgets). Same if reference_opengraph is disabled in server configuration. This leads to several issues:

  • Links that are configured to be displayed as previews don't get displayed at all
  • Links to other pages in the same collective don't get rerouted but instead get opened in a new tab

To Reproduce
Steps to reproduce the behavior:

  • Open a public share of a text file with links configured as link previews

Expected behavior

Some thoughts:

  • I wonder whether we should limit the effect of disabling reference_opengraph to disable previews of external pages and still load references to other objects from the same Nextcloud instance.
  • In public shares (or with reference_opengraph disabled) we have to display links to external pages as text links no matter what.
@mejo- mejo- added bug Something isn't working 29 feedback labels Mar 18, 2024
@mejo- mejo- added this to the Nextcloud 29 milestone Mar 18, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Mar 18, 2024
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Mar 18, 2024
@juliusknorr
Copy link
Member

As discussed in the call:

  • Text: Let's enable the fallback for link previews in the preview node type
  • Server: File a enhancement request for previews on public shares

mejo- added a commit that referenced this issue Jun 19, 2024
@mejo-
fix(Preview): Show reference fallback
1d7cd9b 
Contributes to #5520

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- mentioned this issue Jun 19, 2024
Merged
2 tasks
@mejo- mejo- self-assigned this Jun 19, 2024
@mejo- mejo- moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📝 Office team Jun 19, 2024
backportbot bot pushed a commit that referenced this issue Jun 19, 2024
@mejo- @backportbot
fix(Preview): Show reference fallback
9430fb8 
Contributes to #5520

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- modified the milestones: Nextcloud 29.0.4, Nextcloud 30 Jul 9, 2024
mejo- added a commit to nextcloud/collectives that referenced this issue Jul 16, 2024
@mejo-
feat(PageReference): Public page reference lookups
7b9abad 
Allow to resolve page references by share token to support lookups from
public shares. This adds link previews for links to other pages in the
same collective in public shares.

It requires the new public reference API from nextcloud/server#46378 and
the Text app being built with nextcloud-libraries/nextcloud-vue#5800.

Fixes: #1275
Contributes to nextcloud/text#5520

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- mentioned this issue Jul 16, 2024
Merged
3 tasks
mejo- added a commit to nextcloud/collectives that referenced this issue Jul 16, 2024
@mejo-
feat(PageReference): Public page reference lookups
484cf64 
Allow to resolve page references by share token to support lookups from
public shares. This adds link previews for links to other pages in the
same collective in public shares.

It requires the new public reference API from nextcloud/server#46378 and
the Text app being built with nextcloud-libraries/nextcloud-vue#5800.

Fixes: #1275
Contributes to nextcloud/text#5520

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit to nextcloud/collectives that referenced this issue Jul 17, 2024
@mejo-
feat(PageReference): Public page reference lookups
cb0bb54 
Allow to resolve page references by share token to support lookups from
public shares. This adds link previews for links to other pages in the
same collective in public shares.

It requires the new public reference API from nextcloud/server#46378 and
the Text app being built with nextcloud-libraries/nextcloud-vue#5800.

Fixes: #1275
Contributes to nextcloud/text#5520

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit to nextcloud/collectives that referenced this issue Jul 24, 2024
@mejo-
feat(PageReference): Public page reference lookups
cd09e28 
Allow to resolve page references by share token to support lookups from
public shares. This adds link previews for links to other pages in the
same collective in public shares.

It requires the new public reference API from nextcloud/server#46378 and
the Text app being built with nextcloud-libraries/nextcloud-vue#5800.

Fixes: #1275
Contributes to nextcloud/text#5520

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit to nextcloud/collectives that referenced this issue Jul 24, 2024
@mejo-
feat(PageReference): Public page reference lookups
30b9cd3 
Allow to resolve page references by share token to support lookups from
public shares. This adds link previews for links to other pages in the
same collective in public shares.

It requires the new public reference API from nextcloud/server#46378 and
the Text app being built with nextcloud-libraries/nextcloud-vue#5800.

Fixes: #1275
Contributes to nextcloud/text#5520

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit to nextcloud/collectives that referenced this issue Jul 24, 2024
@mejo-
feat(PageReference): Public page reference lookups
ad14083 
Allow to resolve page references by share token to support lookups from
public shares. This adds link previews for links to other pages in the
same collective in public shares.

It requires the new public reference API from nextcloud/server#46378 and
the Text app being built with nextcloud-libraries/nextcloud-vue#5800.

Fixes: #1275
Contributes to nextcloud/text#5520

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit to nextcloud/collectives that referenced this issue Jul 24, 2024
@mejo-
feat(PageReference): Public page reference lookups
d90167f 
Allow to resolve page references by share token to support lookups from
public shares. This adds link previews for links to other pages in the
same collective in public shares.

It requires the new public reference API from nextcloud/server#46378 and
the Text app being built with nextcloud-libraries/nextcloud-vue#5800.

Fixes: #1275
Contributes to nextcloud/text#5520

Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
Copy link
Member Author

mejo- commented Jul 24, 2024

This is fixed with upgrading to @nextcloud/vue 8.15.0

@mejo- mejo- closed this as completed Jul 24, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mejo- mejo-

Labels
29 feedback bug Something isn't working
Projects
📝 Office team
Archived in project
Milestone
Nextcloud 30
Development

No branches or pull requests
5 participants
@blizzz @Altahrim @juliusknorr @mejo- @skjnldsv