Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable23] fix: update psalm baseline to account for changes in server #2208

Merged
merged 1 commit into from
Mar 1, 2022
Merged

[stable23] fix: update psalm baseline to account for changes in server #2208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 8 additions & 34 deletions tests/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,20 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="4.x-dev@">
<file src="lib/AppInfo/Application.php">
<InvalidArgument occurrences="1">
<code>RegisterDirectEditorEventListener::class</code>
</InvalidArgument>
<UndefinedClass occurrences="3">
<code>BeforeTemplateRenderedEvent</code>
<code>LoadAdditionalScriptsEvent</code>
<code>LoadViewer</code>
</UndefinedClass>
</file>
<file src="lib/Command/ResetDocument.php">
<ImplementedReturnTypeMismatch occurrences="1">
<code>void</code>
</ImplementedReturnTypeMismatch>
</file>
<file src="lib/Controller/DirectSessionController.php">
<UndefinedClass occurrences="1">
<code>InvalidTokenException</code>
</UndefinedClass>
</file>
<file src="lib/Controller/PublicSessionController.php">
<InvalidCatch occurrences="1"/>
<MissingDependency occurrences="1">
<code>ShareNotFound</code>
</MissingDependency>
</file>
<file src="lib/Controller/SettingsController.php">
<UndefinedThisPropertyAssignment occurrences="1">
<code>$this-&gt;userId</code>
Expand All @@ -32,40 +24,30 @@
</UndefinedThisPropertyFetch>
</file>
<file src="lib/Controller/WorkspaceController.php">
<InvalidCatch occurrences="2"/>
<InvalidReturnType occurrences="3">
<code>DataResponse</code>
<code>DataResponse</code>
<code>DataResponse</code>
</InvalidReturnType>
<MissingDependency occurrences="9">
<code>$e</code>
<code>$e</code>
<MissingDependency occurrences="4">
<code>$this-&gt;rootFolder</code>
<code>$this-&gt;rootFolder</code>
<code>IRootFolder</code>
<code>IRootFolder</code>
<code>ShareNotFound</code>
<code>StorageNotAvailableException</code>
<code>StorageNotAvailableException</code>
</MissingDependency>
<UndefinedClass occurrences="1">
<code>Exception</code>
</UndefinedClass>
<UndefinedInterfaceMethod occurrences="1">
<code>open</code>
</UndefinedInterfaceMethod>
<UndefinedThisPropertyFetch occurrences="1">
<code>$this-&gt;logger</code>
</UndefinedThisPropertyFetch>
</file>
<file src="lib/DAV/WorkspacePlugin.php">
<UndefinedClass occurrences="1">
<code>ServerPlugin</code>
</UndefinedClass>
</file>
<file src="lib/Db/SessionMapper.php">
<MoreSpecificImplementedParamType occurrences="1"/>
<MoreSpecificImplementedParamType occurrences="1">
<code>Session update(Session $session)</code>
</MoreSpecificImplementedParamType>
</file>
<file src="lib/Db/StepMapper.php">
<InvalidReturnStatement occurrences="1"/>
Expand Down Expand Up @@ -100,19 +82,14 @@
<UndefinedDocblockClass occurrences="1"/>
</file>
<file src="lib/Service/DocumentService.php">
<InvalidCatch occurrences="3"/>
<InvalidScalarArgument occurrences="1"/>
<MismatchingDocblockReturnType occurrences="1">
<code>Entity</code>
</MismatchingDocblockReturnType>
<MissingDependency occurrences="7">
<MissingDependency occurrences="3">
<code>$this-&gt;rootFolder</code>
<code>IRootFolder</code>
<code>IRootFolder</code>
<code>ShareNotFound</code>
<code>ShareNotFound</code>
<code>ShareNotFound</code>
<code>ShareNotFound</code>
</MissingDependency>
<UndefinedClass occurrences="2">
<code>File</code>
Expand Down Expand Up @@ -167,9 +144,6 @@
<InvalidNullableReturnType occurrences="1">
<code>\OCP\Files\File</code>
</InvalidNullableReturnType>
<MissingDependency occurrences="1">
<code>StorageNotAvailableException</code>
</MissingDependency>
<NullableReturnStatement occurrences="1">
<code>null</code>
</NullableReturnStatement>
Expand Down