Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable23] display content first and then load menus #2228

Merged
merged 2 commits into from
Mar 10, 2022
Merged

[stable23] display content first and then load menus #2228

merged 2 commits into from
Mar 10, 2022

Commits on Mar 9, 2022

  1. display content first and then load menus 

    Rendering the menubar and menububble takes a significant amount of time.
First display the content and then render the menus.

Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    dbbbd9d View commit details
    Browse the repository at this point in the history

  2. refactor: extract logic into computed 

    Also rename `initialLoading` in `EditorWrapper` to `contentLoaded`.
This flag is set during the `initialLoading` state change.
It does indicates that the loading happened
Use the past tense to indicate that.

The editor wrapper is now loading in different steps.
The menus will load after the content.
So `content` seems more fitting then `initial`.

Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    7688777 View commit details
    Browse the repository at this point in the history