Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable23] fix: menu bubble size at the end of the line #2277

Merged
merged 4 commits into from
Apr 6, 2022
Merged

[stable23] fix: menu bubble size at the end of the line #2277

merged 4 commits into from
Apr 6, 2022

Commits on Apr 5, 2022

  1. fix: menu bubble size at the end of the line 

    Compute menu bubble position without translateX.
The previous approach made the bubble shrink
towards the end of the line.

Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    41a04a2 View commit details
    Browse the repository at this point in the history

  2. ui: maintain menu bubble size 

    When selecting the right-most chars in a line
the menu bubble was getting too small.

Meassure the menu bubble when it is drawn but still hidden.
Calculate its position based on the editor width and the meassured bubble width.

Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    23402ca View commit details
    Browse the repository at this point in the history

  3. ui: reduce padding around workspace on mobile 

    Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    f6c710c View commit details
    Browse the repository at this point in the history

  4. build: compile js 

    Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    dc34d7f View commit details
    Browse the repository at this point in the history