-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow opening files outside of the file system in viewer #2832
Conversation
33a17b9
to
55797d1
Compare
2 flaky tests on run #11554 ↗︎
Details:
SyncServiceProvider.spec.js • 1 flaky test
UsersApi.spec.js • 1 flaky test
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
55797d1
to
0688318
Compare
I've updated the checklist above, when giving it another test run together with the versions PR i think there are a few more topics to address, added to the description. |
878308e
to
420d551
Compare
@ChristophWurst FYI we will merge and backport this for 27.1. Iirc you had a mimetype filter in mail so might be a quick win to enable preview for markdown attachments then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor remark. Other than that... good to go from my side.
420d551
to
d91463d
Compare
d91463d
to
cba8cfc
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
cba8cfc
to
b35a369
Compare
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
/backport 246f158,67f01011cd16b62d153a8593bc49fc55b3c10b20,b35a36968cc33270502133fb44d0a187864b7d4e to stable27 |
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Some early PoC for displaying text file attachments from mail in viewer
Follow up / separate
cc @ChristophWurst