Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow opening files outside of the file system in viewer #2832

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 24, 2022

Some early PoC for displaying text file attachments from mail in viewer

Follow up / separate

cc @ChristophWurst

@cypress
Copy link

cypress bot commented Jul 13, 2023

2 flaky tests on run #11554 ↗︎

0 149 2 0 Flakiness 2

Details:

Allow opening files outside of the file system in viewer
Project: Text Commit: b35a36968c
Status: Passed Duration: 03:39 💡
Started: Aug 7, 2023 5:17 PM Ended: Aug 7, 2023 5:21 PM
Flakiness  SyncServiceProvider.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync service provider > recovers from a dropped message Output Screenshots
Flakiness  UsersApi.spec.js • 1 flaky test

View Output Video

Test Artifacts
The user mention API > fetches users with valid session Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr
Copy link
Member Author

I've updated the checklist above, when giving it another test run together with the versions PR i think there are a few more topics to address, added to the description.

@juliusknorr juliusknorr marked this pull request as ready for review August 7, 2023 10:40
@juliusknorr
Copy link
Member Author

@ChristophWurst FYI we will merge and backport this for 27.1. Iirc you had a mimetype filter in mail so might be a quick win to enable preview for markdown attachments then

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor remark. Other than that... good to go from my side.

src/components/ViewerComponent.vue Outdated Show resolved Hide resolved
@juliusknorr juliusknorr force-pushed the enh/mail-attachments branch from 420d551 to d91463d Compare August 7, 2023 12:26
@mejo- mejo- force-pushed the enh/mail-attachments branch from d91463d to cba8cfc Compare August 7, 2023 13:25
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the enh/mail-attachments branch from cba8cfc to b35a369 Compare August 7, 2023 17:15
@juliusknorr
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliusknorr juliusknorr enabled auto-merge August 7, 2023 17:34
@juliusknorr juliusknorr merged commit 700d729 into main Aug 7, 2023
@juliusknorr juliusknorr deleted the enh/mail-attachments branch August 7, 2023 17:36
@mejo-
Copy link
Member

mejo- commented Aug 8, 2023

/backport 246f158,67f01011cd16b62d153a8593bc49fc55b3c10b20,b35a36968cc33270502133fb44d0a187864b7d4e to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants