feat: update render markdown for tables #4390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 failed and 3 flaky tests on run #11873 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Test all attachment insertion methods > test if attachment folder is deleted after having deleted a markdown file |
Output
Screenshots
|
|
share.spec.js • 2 flaky tests
| Test | Artifacts | |
|---|---|---|
| Open test.md in viewer > Shares the file as a public read only link |
Output
Screenshots
|
|
| Open test.md in viewer > Share a file with download disabled shows an error |
Output
Screenshots
|
|
api/SyncServiceProvider.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Sync service provider > recovers from a dropped message |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
Cypress failure looks unrelated, but can you check the jest tests again @luka-nextcloud ? |
luka-nextcloud
force-pushed
the
feature/render-markdown-for-tables
branch
from
dc55e9c
to
e3bb72d
Compare
max-nextcloud
approved these changes
Aug 21, 2023
|
funny that the node check is passing without a compile. |
|
/backport e3bb72d to stable27 |
max-nextcloud
force-pushed
the
feature/render-markdown-for-tables
branch
from
e3bb72d
to
1c63fab
Compare
|
/compile |
max-nextcloud
force-pushed
the
feature/render-markdown-for-tables
branch
from
7a4fff2
to
c587f55
Compare
|
/compile |
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
max-nextcloud
force-pushed
the
feature/render-markdown-for-tables
branch
from
e109f0e
to
1c168c0
Compare
|
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
@luka-nextcloud Can you take care of the manual backport please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)