Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax highlighting in code blocks #4592

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Add syntax highlighting in code blocks #4592

merged 2 commits into from
Jul 28, 2023

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Jul 28, 2023

Fixes: #3618

Also only load core highlight JS package in EditorFactory.js (required for syntax highlighting in plaintext editing). This reduces the size for compiled editor.js by almost 1MB.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing
  • Documentation is not required

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Wow! So little changes - so much impact!

Fixes: #3618

Also only load core highlight JS package in EditorFactory.js (required
for syntax highlighting in plaintext editing). This reduces the size ofr
compiled editor.js by almost 1MB.

Signed-off-by: Jonas <jonas@freesources.org>
@max-nextcloud
Copy link
Collaborator

/compile

@mejo-
Copy link
Member Author

mejo- commented Jul 28, 2023

/backport f1a0fea to stable26

@mejo-
Copy link
Member Author

mejo- commented Jul 28, 2023

/backport f1a0fea to stable27

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@cypress
Copy link

cypress bot commented Jul 28, 2023

1 flaky tests on run #11360 ↗︎

0 149 2 0 Flakiness 1

Details:

Add syntax highlighting in code blocks
Project: Text Commit: 70f29274da
Status: Passed Duration: 05:19 💡
Started: Jul 28, 2023 10:56 AM Ended: Jul 28, 2023 11:02 AM
Flakiness  cypress/e2e/api/SyncServiceProvider.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync service provider > recovers from a dropped message Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mejo- mejo- merged commit 41ec967 into main Jul 28, 2023
29 checks passed
@mejo- mejo- deleted the enh/codeblock_highlight branch July 28, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax highlighting doesn't work in code blocks in markdown
3 participants