Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Limit asset/source loader rule to inline svg embeddings from @mdi/svg #4997

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix: Limit asset/source loader rule to inline svg embeddings from @mdi/svg #4997

merged 1 commit into from
Nov 13, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 13, 2023 •
edited
Loading

Fix checkbox icons that were broken due to using the wrong rule:

Screenshot 2023-11-13 at 09 35 58

@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Nov 13, 2023
@juliusknorr
fix: Limit asset/source loader rule to inline svg embeddings from @md…
6227bbc 
…i/svg

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/noid/checkbox-svg branch from 8367252 to 6227bbc Compare November 13, 2023 09:50
@juliusknorr juliusknorr changed the title fix: Limit asset/source loader rule to resource query ?raw= fix: Limit asset/source loader rule to inline svg embeddings from @mdi/svg Nov 13, 2023
datenangebot
datenangebot approved these changes Nov 13, 2023
View reviewed changes
Copy link

@datenangebot datenangebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

mejo-
mejo- approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't fully understand the logic around webpack raw-loader, webpack rules and loading the FilePlus icon as raw SVG, the PR indeed fixes the issue at hand in my local tests.

@juliusknorr juliusknorr mentioned this pull request Nov 13, 2023
Merged
@juliusknorr juliusknorr merged commit c15c3d5 into main Nov 13, 2023
32 of 34 checks passed
@juliusknorr juliusknorr deleted the bugfix/noid/checkbox-svg branch November 13, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datenangebot datenangebot datenangebot approved these changes

@mejo- mejo- mejo- approved these changes

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

Assignees
No one assigned
Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @mejo- @datenangebot