Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @nextcloud/files to ^3.1.0 (stable26) #5251

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 13, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@nextcloud/files ^3.0.0-beta.11 -> ^3.1.0 age adoption passing confidence

Release Notes

nextcloud-libraries/nextcloud-files (@​nextcloud/files)

v3.1.0

Compare Source

Enhancements
Fixed

v3.0.0

Compare Source

Breaking
Enhancements
Fixed

Full Changelog: nextcloud-libraries/nextcloud-files@v2.1.0...v3.0.0

v3.0.0-beta.27

Compare Source

3.0.0-beta.27 - 2023-11-03

Full Changelog

Enhancements
Fixed
Dependencies

v3.0.0-beta.26

Compare Source

3.0.0-beta.26 - 2023-10-11

Full Changelog

Enhancements

Dependencies

v3.0.0-beta.25

Compare Source

3.0.0-beta.25 - 2023-10-03

Full Changelog

Enhancements

v3.0.0-beta.24: v3.0.0-beta.24

Compare Source

3.0.0-beta.24 - 2023-09-25

Full Changelog

Fixed

v3.0.0-beta.23

Compare Source

3.0.0-beta.23 - 2023-09-25

Full Changelog

Enhancements
  • feat(parseFileSize): Added parseFileSize function to parse a human readable file size to number of bytes #​769 (@​susnux)
Fixed

v3.0.0-beta.22

Compare Source

What's Changed

New Contributors

Full Changelog: nextcloud-libraries/nextcloud-files@v3.0.0-beta.21...v3.0.0-beta.22

v3.0.0-beta.21

Compare Source

3.0.0-beta.21 - 2023-09-01

Full Changelog

Fixed

v3.0.0-beta.20

Compare Source

3.0.0-beta.20 - 2023-08-29

Full Changelog

Enhancements

v3.0.0-beta.19

Compare Source

3.0.0-beta.19 - 2023-08-24

Full Changelog

Fixed
  • fix(dav): Fix resultToNode by adding some documenation how to use #​741 (@​susnux)
  • fix(newfilemenu): fix handler requirement, deprecate iconClass and fix context #​742 (@​skjnldsv)

v3.0.0-beta.18

Compare Source

3.0.0-beta.18 - 2023-08-23

Full Changelog

Fixed

v3.0.0-beta.17

Compare Source

3.0.0-beta.17 - 2023-08-23

Full Changelog

Fixed

v3.0.0-beta.16

Compare Source

3.0.0-beta.16 - 2023-08-18

Full Changelog

Enhancements
Fixed

v3.0.0-beta.15

Compare Source

3.0.0-beta.15 - 2023-08-18

Full Changelog

Fixed
Enhancements

v3.0.0-beta.14

Compare Source

What's Changed

Full Changelog: nextcloud-libraries/nextcloud-files@v3.0.0-beta.13...v3.0.0-beta.14

v3.0.0-beta.13

Compare Source

3.0.0-beta.13 - 2023-08-03

Full Changelog

Fixed
Changed

v3.0.0-beta.12

Compare Source

3.0.0-beta.12 - 2023-08-01

Full Changelog

Enhancements
Fixed
Changed

Configuration

📅 Schedule: Branch creation - "every weekend" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Jan 13, 2024
Copy link

cypress bot commented Jan 13, 2024

2 flaky tests on run #12420 ↗︎

0 150 2 0 Flakiness 2

Details:

fix(deps): update dependency @nextcloud/files to ^3.1.0 (stable26)
Project: Text Commit: a4a72c9a80
Status: Passed Duration: 02:58 💡
Started: Jan 13, 2024 2:50 PM Ended: Jan 13, 2024 2:53 PM
Flakiness  cypress/e2e/sync.spec.js • 2 flaky tests

View Output

Test Artifacts
Sync > saves the actual file and document state Screenshots
Sync > saves on close Screenshots

Review all test suite changes for PR #5251 ↗︎

@max-nextcloud
Copy link
Collaborator

According to https://github.com/nextcloud-libraries/nextcloud-files/blob/master/CHANGELOG.md @nextcloud/files from 3.0 on requires node 20 and npm 9. We might not be using these for stable26.

I wonder if we should just stick to 2.x on the stable26 and maybe even stable27 branches.

@max-nextcloud
Copy link
Collaborator

probably superseeded by #5264

Copy link
Contributor Author

renovate bot commented Jan 15, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (^3.1.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/stable26-nextcloud-files-3.x branch January 15, 2024 09:13
max-nextcloud added a commit that referenced this pull request Jan 15, 2024
* Forward ports: #5264
* Resolves: failing build in #5251

`@nextcloud/files` requires node 20 and npm 9. This dependency was introduced based on a beta version that did not have these requirements yet. Roll back to version 2 rather than updating the entire node stack.

Only difference here is that `formatFileSize` which we use will default to non-binary file sizes - i.e 1.024KB instead of 1KiB as this only became available with v3:
* https://github.com/nextcloud-libraries/nextcloud-files/pull/770/files#diff-237392127cb275fc6789cf6faec014d758950c87ccdab0329dde793d034190d8

Signed-off-by: Max <max@nextcloud.com>
juliushaertl pushed a commit that referenced this pull request Jan 15, 2024
* Forward ports: #5264
* Resolves: failing build in #5251

`@nextcloud/files` requires node 20 and npm 9. This dependency was introduced based on a beta version that did not have these requirements yet. Roll back to version 2 rather than updating the entire node stack.

Only difference here is that `formatFileSize` which we use will default to non-binary file sizes - i.e 1.024KB instead of 1KiB as this only became available with v3:
* https://github.com/nextcloud-libraries/nextcloud-files/pull/770/files#diff-237392127cb275fc6789cf6faec014d758950c87ccdab0329dde793d034190d8

Signed-off-by: Max <max@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant