Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: document status bar #5321

Closed
wants to merge 1 commit into from
Closed

fix: document status bar #5321

wants to merge 1 commit into from

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Jan 30, 2024

📝 Summary

Fixes the alignment and positioning of the document status bar

🏚️ Before | 🏡 After
Before: #4483 (comment)

After:
no-locked-file.webm

🚧 TODO

Tested on

  • Single file opened in the viewer as a logged in user
  • Open a file on a public share link of that file
  • Open a file on a publich share link of a folder
    Make sure to test this with Talk enabled and disabled as talk registers a sidebar on the public share pages
  • Collectives regular page and share links
  • Notes

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@enjeck
Copy link
Contributor Author

enjeck commented Mar 12, 2024

@mejo- @max-nextcloud Still looking into the failing tests, but do you have any feedback on this? I don't like that I had to add a new div for this, and wondering if there's a better way I could have done it.

@enjeck
Copy link
Contributor Author

enjeck commented Mar 22, 2024

No longer necessary. Addressed at 59e6bf5

@enjeck enjeck closed this Mar 22, 2024
@enjeck enjeck deleted the fix/4483-4905 branch March 22, 2024 14:39
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document status bar not aligned with editor
1 participant