Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only unpause focus traps that we paused ourselves #5327

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jan 31, 2024

Fix #5326

Still need to check if there is a more elegant approach, but this seems to fix it.

Also to double check, probably for a separate issue

  • Having a link after a code block will allow tabbing out of the paused focus trap

Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be fixed, thank you Julius!

Solution should not be perfect for now. Let's merge if it solve a problem ;)

@JuliaKirschenheuter
Copy link
Contributor

/backport to stable28

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr marked this pull request as ready for review February 1, 2024 08:14
@juliusknorr juliusknorr added the bug Something isn't working label Feb 1, 2024
@juliusknorr juliusknorr merged commit 43f8a38 into main Feb 1, 2024
53 checks passed
@juliusknorr juliusknorr deleted the bugfix/5326 branch February 1, 2024 08:26
@juliusknorr
Copy link
Member Author

/backport to stable28

Copy link

backportbot bot commented Feb 1, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/5327/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c22d700a37654d5e7ad74397b9c33307ea56d991

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5327/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@juliusknorr
Copy link
Member Author

Needs #5318 first

@juliusknorr
Copy link
Member Author

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: focus will be set on actions as far document will be saved
2 participants