-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Only unpause focus traps that we paused ourselves #5327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be fixed, thank you Julius!
Solution should not be perfect for now. Let's merge if it solve a problem ;)
/backport to stable28 |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
9ca1679
to
c22d700
Compare
/backport to stable28 |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/5327/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c22d700a37654d5e7ad74397b9c33307ea56d991
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5327/stable28 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Needs #5318 first |
/backport to stable28 |
Fix #5326
Still need to check if there is a more elegant approach, but this seems to fix it.
Also to double check, probably for a separate issue