Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump prosemirror-trailing-node to 2.0.8 #5438

Merged
merged 1 commit into from
Apr 2, 2024
Merged

build(deps): bump prosemirror-trailing-node to 2.0.8 #5438

merged 1 commit into from
Apr 2, 2024

Conversation

LoneRifle
Copy link
Contributor

@LoneRifle LoneRifle commented Mar 5, 2024

📝 Summary

Bump prosemirror-trailing-node to 2.0.8 to pick up remirror/remirror#2245, which drops @remirror/core-helpers.
The latter package was heavy, bringing in several additional dependencies, but was only used to create
an array of unique elements, and to check for the presence of elements in arrays.

Accordingly, they have been replaced in 2.0.8 with equivalent code that relies on standard built-in objects.

This PR has been submitted through the course of work for @opengovsg

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@LoneRifle
Copy link
Contributor Author

@mejo- not sure what happened with the Cypress 5 runner test, but it doesn't appear related to my PR:
https://github.com/nextcloud/text/actions/runs/8271282152/job/22630827977

Signed-off-by: LoneRifle <LoneRifle@users.noreply.github.com>
@mejo-
Copy link
Member

mejo- commented Apr 2, 2024

Thanks for the contribution @LoneRifle.

I manually checked that this PR does nothing more than npm update prosemirror-trailing-node.

@mejo- mejo- merged commit ae7c8af into nextcloud:main Apr 2, 2024
58 checks passed
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants