Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): Accept pushs with only step1 messages by read-only clients #5466

Merged
merged 2 commits into from
Mar 12, 2024
Merged

fix(backend): Accept pushs with only step1 messages by read-only clients #5466

merged 2 commits into from
Mar 12, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Mar 12, 2024

📝 Summary

This fixes read-only clients getting 403 responses on push requests that only contain questions for updates.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation is not required

juliushaertl
juliushaertl approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small naming nitpick, otherwise looks sane 👍

@mejo- mejo- force-pushed the fix/read_only_pushs branch 2 times, most recently from 0e08405 to dc268a9 Compare March 12, 2024 20:49
@mejo- mejo- added this to the Nextcloud 29 milestone Mar 12, 2024
@mejo-
fix(backend): Accept pushs with only step1 messages by read-only clients
a43d77c 
This fixes read-only clients getting 403 responses on push requests that
only contain questions for updates.

Fixes: #5223
Fixes: #5366
Fixes: #5368

Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
fix(ci): Add back 'npm' cache option to setup-node action runs
e794653 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- merged commit c9f3af6 into main Mar 12, 2024
63 checks passed
@mejo- mejo- deleted the fix/read_only_pushs branch March 12, 2024 22:06
@mejo-
Copy link
Member Author

mejo- commented Mar 13, 2024

/backport to stable28

@mejo-
Copy link
Member Author

mejo- commented Mar 13, 2024

/backport to stable27

@backportbot backportbot bot mentioned this pull request Mar 13, 2024
Merged
2 tasks
@backportbot backportbot bot mentioned this pull request Mar 13, 2024
Merged
2 tasks
@Altahrim Altahrim mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

Assignees
No one assigned
Labels
2. developing
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

403 on public share access 403 errors in NGINX Failed to write to document errors in readonly sessions
2 participants
@mejo- @juliushaertl