Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(attachments): Don't use currentSession for fetching attachments #5484

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix(attachments): Don't use currentSession for fetching attachments #5484

merged 1 commit into from
Mar 14, 2024

Commits on Mar 14, 2024

  1. fix(attachments): Don't use currentSession for fetching attachments 

    When switching pages in Collectives, `currentSession` might still be the
session from the last page. The readonly view (`MarkdownContentEditor`)
doesn't get a session, so the outdated session is used.

Instead, always pass the session from `AttachmentResolver` to
`setAttachmentList`.

Fixes: nextcloud/collectives#1096
Fixes: nextcloud/collectives#1112

Signed-off-by: Jonas <jonas@freesources.org>
    @mejo-
    mejo- committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    201a363 View commit details
    Browse the repository at this point in the history