Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(LinkBubble): Treat links to hashes in same page directly #5521

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix(LinkBubble): Treat links to hashes in same page directly #5521

merged 1 commit into from
Apr 4, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Mar 18, 2024

Fixes: #5495

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo- mejo- added bug Something isn't working 3. to review 29 feedback labels Mar 18, 2024
@mejo- mejo- added this to the Nextcloud 29 milestone Mar 18, 2024
@mejo- mejo- self-assigned this Mar 18, 2024
@Altahrim Altahrim mentioned this pull request Mar 18, 2024
Merged
@mejo- mejo- force-pushed the fix/link_bubble_hash_to_same_page branch 2 times, most recently from 7d137e6 to 60d10f9 Compare March 18, 2024 17:55
@Altahrim Altahrim mentioned this pull request Mar 20, 2024
Merged
@mejo- mejo- force-pushed the fix/link_bubble_hash_to_same_page branch 3 times, most recently from 78d21af to d37e525 Compare March 20, 2024 17:41
max-nextcloud
max-nextcloud approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Linter fails though.

@mejo-
Copy link
Member Author

mejo- commented Mar 21, 2024

looks good to me. Linter fails though.

Linter failure was a CI hickup. But the Cypress failures might be related. Will have to look into them next week.

@mejo- mejo- force-pushed the fix/link_bubble_hash_to_same_page branch from d37e525 to d0e25e2 Compare March 22, 2024 09:57
@Altahrim Altahrim mentioned this pull request Mar 25, 2024
Merged
@mejo- mejo- force-pushed the fix/link_bubble_hash_to_same_page branch from d0e25e2 to d1ce2e0 Compare March 25, 2024 16:23
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@blizzz blizzz mentioned this pull request Apr 4, 2024
Merged
67 tasks
@mejo-
fix(LinkBubble): Treat links to hashes in same page directly
c89a0aa 
Fixes: #5495

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/link_bubble_hash_to_same_page branch from d1ce2e0 to c89a0aa Compare April 4, 2024 12:30
@mejo-
Copy link
Member Author

mejo- commented Apr 4, 2024

/backport to stable29

@mejo- mejo- merged commit 7915402 into main Apr 4, 2024
59 checks passed
@mejo- mejo- deleted the fix/link_bubble_hash_to_same_page branch April 4, 2024 12:50
@backportbot backportbot bot mentioned this pull request Apr 4, 2024
Merged
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@grnd-alt grnd-alt Awaiting requested review from grnd-alt

Assignees

@mejo- mejo-

Labels
3. to review 29 feedback bug Something isn't working
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

Link with full URL to the same document should behave like a link with just the anchor
2 participants
@mejo- @max-nextcloud