Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): Adjust heading sizes (Fixes: #5515) #5594

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Apr 2, 2024

πŸ“ Summary

Fixes: #5515

Also aligns with nextcloud/server#43640

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
Screenshot 2024-04-02 at 16-25-54 headings md - Nextcloud Screenshot 2024-04-02 at 16-27-37 headings md - Nextcloud

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo-
Copy link
Member Author

mejo- commented Apr 2, 2024

/backport to stable29

Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much nicer, thanks @mejo- πŸ‘

Let's wait for @jancborchardt to double check

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me!
Let's wait for designers :)

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well :)

@juliushaertl
Copy link
Member

@mejo- Mind to update the print screenshots used to compare in the CI?

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, much better :)

Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
Copy link
Member Author

mejo- commented Apr 3, 2024

@mejo- Mind to update the print screenshots used to compare in the CI?

Did now, thanks for the pointer 😊

@juliushaertl juliushaertl merged commit 5cc7750 into main Apr 3, 2024
59 checks passed
@juliushaertl juliushaertl deleted the fix/heading_css branch April 3, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS: reduce size differential between headings and text
5 participants