Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve node and mark copy-paste behavior #5654

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Apr 10, 2024

📝 Summary

Resolves #5650, #5480

This PR introduces better handling for various copy-paste situations which present issues. Namely, it resolves all of the following issues with copy-pasting:

  • Copying from a code block should just paste the code in question
  • Copying multiple list items should result in something that resembles a list
  • Copying version numbers should not result in an escaped character (28\.0.3 e.g.)
  • Copying a larger fragment of a doc should result in markdown as this can be useful for creating github issues
  • Copying an address from inside a info block should only result in the address
  • Copy two paragraphs of text with bold, italic, etc formatting into the Signal Desktop Client or the text-only body field of your mail client
  • Copy a list of email address links that spans over several blocks (e.g. [mail@example.org](mailto:mail@example.org)\n\n[mail2@example.org](mailto:mail2@example.org) into the recipient field of any mail client (Thunderbird, Roundcube)

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@max-nextcloud
Copy link
Collaborator

/backport to stable29

@max-nextcloud
Copy link
Collaborator

/backport to stable28

@max-nextcloud max-nextcloud merged commit 52bf5a5 into main Apr 11, 2024
58 checks passed
@max-nextcloud max-nextcloud deleted the fix/improve-copy-paste branch April 11, 2024 11:07
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
2 participants