Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(links): 5539 close link bubble on click outside #5691

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix(links): 5539 close link bubble on click outside #5691

merged 1 commit into from
Apr 17, 2024

Conversation

max-nextcloud
Copy link
Collaborator

📝 Summary

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation is not required

@max-nextcloud max-nextcloud marked this pull request as ready for review April 16, 2024 12:07
@max-nextcloud
fix(links): 5539 close link bubble on click outside
e571ae6 
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud added this to the Nextcloud 29 milestone Apr 17, 2024
@Altahrim Altahrim mentioned this pull request Apr 17, 2024
Merged
9 tasks
@blizzz blizzz modified the milestones: Nextcloud 29, Nextcloud 30 Apr 17, 2024
@blizzz
Copy link
Member

blizzz commented Apr 17, 2024

fyi, adjusted milestone, main is NC 30

mejo-
mejo- approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well. Also, checking if the event targets an element outside tippy is cleaner than checking the node type 👌

@mejo-
Copy link
Member

mejo- commented Apr 17, 2024

/backport to stable29

@max-nextcloud max-nextcloud merged commit 66538c5 into main Apr 17, 2024
58 checks passed
@max-nextcloud max-nextcloud deleted the fix/close-link-bubble branch April 17, 2024 15:23
@backportbot backportbot bot mentioned this pull request Apr 17, 2024
Merged
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees
No one assigned
Labels
3. to review
Projects
📝 Office team
Archived in project
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

Link bubble: click outside no longer closes the bubble
3 participants
@max-nextcloud @blizzz @mejo-