fix: disable callouts button when all callout variants are disabled #5720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luka-nextcloud
requested review from
juliusknorr,
elzody,
enjeck and
max-nextcloud
max-nextcloud
requested changes
Apr 23, 2024
There was a problem hiding this comment.
Failing Jest and Cypress component tests are not related I think.
Cypress is failing for an interesting reason:
In the word count tests the remain menu cannot be opened as all actions in it are not availabe. So in a way your changes are working - you will need to account for the special case of the word count entry though.
luka-nextcloud
force-pushed
the
disable-callouts-button-when-all-variants-disabled
branch
from
26cdebe
to
b64d837
Compare
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Check if there is any child that is enabled. This is somewhat simpler than storing an array of the disabled children and comparing it's length to the length of the array of non-seperator children. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
luka-nextcloud
force-pushed
the
disable-callouts-button-when-all-variants-disabled
branch
from
daab3ce
to
cd1641b
Compare
max-nextcloud
approved these changes
Apr 30, 2024
luka-nextcloud
deleted the
disable-callouts-button-when-all-variants-disabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)