Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Add keyboard shortcut (Ctrl-Alt-H) to toggle outline #5799

Merged
merged 3 commits into from
May 15, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented May 15, 2024

Fixes: #5798

Edit: shortcut changed to Ctrl-Alt-H like it's in Google Docs.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo- mejo- added bug Something isn't working enhancement New feature or request 3. to review labels May 15, 2024
mejo- added 3 commits May 15, 2024 16:12
Fixes: #5798

Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- changed the title feat(editor): Add keyboard shortcut (Ctrl-Alt-O) to toggle outline feat(editor): Add keyboard shortcut (Ctrl-Alt-H) to toggle outline May 15, 2024
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. did not try it though.
Oh... and maybe have a cypress test for it so we don't break it without noticing?

@juliusknorr juliusknorr merged commit 109c376 into main May 15, 2024
60 checks passed
@juliusknorr juliusknorr deleted the feat/outline_shortcut branch May 15, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shortcut to display page structure
3 participants