Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: showing folder description on favorites #5802

Merged
merged 1 commit into from
May 28, 2024
Merged

fix: showing folder description on favorites #5802

merged 1 commit into from
May 28, 2024

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented May 17, 2024 •
edited by skjnldsv
Loading

📝 Summary

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@luka-nextcloud luka-nextcloud self-assigned this May 17, 2024
@luka-nextcloud luka-nextcloud added bug Something isn't working 3. to review labels May 17, 2024
mejo-
mejo- approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change look good to me 👌

@luka-nextcloud
fix: showing folder description on favorites
ef17cea 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@luka-nextcloud luka-nextcloud force-pushed the bugfix/folder-description-on-favourites branch from 5b09152 to ef17cea Compare May 20, 2024 19:29
@luka-nextcloud luka-nextcloud merged commit 3855858 into main May 28, 2024
60 checks passed
@luka-nextcloud luka-nextcloud deleted the bugfix/folder-description-on-favourites branch May 28, 2024 06:19
@luka-nextcloud luka-nextcloud mentioned this pull request Jul 12, 2024
Closed
@luka-nextcloud
Copy link
Contributor Author

/backport to stable28

@backportbot backportbot bot mentioned this pull request Jul 12, 2024
Merged
@luka-nextcloud
Copy link
Contributor Author

/backport to stable29

@backportbot backportbot bot mentioned this pull request Jul 12, 2024
Merged
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 1, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

Assignees

@luka-nextcloud luka-nextcloud

Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No folder description in Favorites from 28 on
2 participants
@luka-nextcloud @mejo-