fix(ci): handle grep with no results gracefully #5826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`grep` will return an exit code of 1 if no result was found. Check for that and let the job continue. In case of errors grep will return a higher exit code and the job will abort as intended. Signed-off-by: Max <max@nextcloud.com>
hweihwang
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grepwill return an exit code of 1 if no result was found.Check for that and let the job continue.
In case of errors grep will return a higher exit code and the job will abort as intended.
🖼️ Screenshots
🏚️ Before
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)