-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: smartpicker set links for selected text #5832
Conversation
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@enjeck seems like the screencast is broken/wrong. At least there's nothing happening there 😉 |
Replaced! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, works well 😊
/backport to stable29 |
/backport to stable28 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
📝 Summary
If a text is selected, the smartpicker links the selected text. If nothing is selected, it inserts the link.
🖼️ Video
Screencast.from.05-27-2024.06.36.27.AM.webm
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)