Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: smartpicker set links for selected text #5832

Merged
merged 1 commit into from
May 27, 2024
Merged

fix: smartpicker set links for selected text #5832

merged 1 commit into from
May 27, 2024

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented May 27, 2024

📝 Summary

If a text is selected, the smartpicker links the selected text. If nothing is selected, it inserts the link.

🖼️ Video

Screencast.from.05-27-2024.06.36.27.AM.webm

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@mejo-
Copy link
Member

mejo- commented May 27, 2024

@enjeck seems like the screencast is broken/wrong. At least there's nothing happening there 😉

@enjeck
Copy link
Contributor Author

enjeck commented May 27, 2024

@enjeck seems like the screencast is broken/wrong. At least there's nothing happening there 😉

Replaced!

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works well 😊

@mejo- mejo- merged commit 8de35ca into main May 27, 2024
60 checks passed
@mejo- mejo- deleted the fix/4783 branch May 27, 2024 13:32
@mejo-
Copy link
Member

mejo- commented May 27, 2024

/backport to stable29

@mejo-
Copy link
Member

mejo- commented May 27, 2024

/backport to stable28

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

smart picker can't set links for selected section of text / workflow for linking to resources
3 participants