perf: Lazy load optional dependencies #5886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Mermaid JS and its dependency elkjs is a huge depenency (6MiB and 3MiB compressed), so we only should load it if required. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
juliushaertl
approved these changes
Jun 11, 2024
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Currently mermaid JS is always imported, but mermaid JS is huge (6MiB code and 3MiB minified).
So instead this imports the mermaid module only if really required the first time.
This will reduce the default loading of the text app by ~1MiB gziped assets.
Also make a custom chunk for the emoji picker to split the nextcloud vue chunk into better loadable ones (2x 700kiB instead of 1500 kiB).
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)