Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): use reactive hasEditor in template #5943

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix(editor): use reactive hasEditor in template #5943

merged 1 commit into from
Jun 25, 2024

Conversation

max-nextcloud
Copy link
Collaborator

$editor is not (meant to be) reactive.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • no tests
  • no docs

@max-nextcloud
fix(editor): use reactive hasEditor in template
453048f 
`$editor` is not (meant to be) reactive.

Signed-off-by: Max <max@nextcloud.com>
@juliushaertl juliushaertl merged commit deb3a73 into main Jun 25, 2024
59 of 61 checks passed
@juliushaertl juliushaertl deleted the fix/use-has-editor branch June 25, 2024 06:08
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-nextcloud @juliushaertl