Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Take shortcut for remaining getById if we can #5947

Merged
merged 1 commit into from
Jun 26, 2024
Merged

perf: Take shortcut for remaining getById if we can #5947

merged 1 commit into from
Jun 26, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Jun 25, 2024 •
edited
Loading

Follow up to #5933 to add a shortcut for cases where we can optimize to use the faster cached method.

@juliushaertl
perf: Take shortcut for remaining getById if we can
63bee14 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
mejo-
mejo- approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me.

@juliushaertl juliushaertl merged commit 6cb4f07 into main Jun 26, 2024
61 of 63 checks passed
@juliushaertl juliushaertl deleted the perf/node-by-id branch June 26, 2024 10:54
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@elzody elzody Awaiting requested review from elzody

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

Assignees
No one assigned
Labels
3. to review performance 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliushaertl @mejo-