Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Skip cypress test crashing electron right now #5952

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Jun 26, 2024

To open a revert right afterwards to not forget, but for now this should not block us from passing CI for easier merges

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added tests If you write them we ♥ you 3. to review labels Jun 26, 2024
@juliushaertl
Copy link
Member Author

Planned to skip the other on as well but noticed @mejo- is looking into that right now in #5951

@juliushaertl
Copy link
Member Author

/backport to stable29

@juliushaertl
Copy link
Member Author

/backport to stable28

@juliushaertl
Copy link
Member Author

/backport to stable27

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Only needs backport to stable29 though.

@mejo-
Copy link
Member

mejo- commented Jun 26, 2024

The failing workspace test should be fixed instead, it's not related to the electron crashes.

@juliushaertl juliushaertl merged commit 533a724 into main Jun 26, 2024
59 of 61 checks passed
@juliushaertl juliushaertl deleted the ci/skip-crashing-test branch June 26, 2024 13:15
Copy link

backportbot bot commented Jun 26, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/5952/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2622db67

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5952/stable27

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review tests If you write them we ♥ you
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants