fix(sync): reuse open connection #6054
Conversation
|
Chances are this will actually fix #6050 as the newly created sessions come with polling backends and the old polling backends keep running in parallel. So once the current session is closed the other polling backends will continue running and hand the session list to the sync service which still has the closed session and then fails to find it in the session list. So the currentSession ends up getting cleared. |
Do not attempt to create a new connection if there already is one and it is not closed. If no messages are received for 30 seconds yjs will open a new websocket. Since we do not close the connection anymore from the websocket polyfill we also do not need to open it. If the network connection has gone down creating a new connection will fail anyway. Once it comes back we will know if the session is still valid. Then we can either continue using it or reconnect. This is part of #6050. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
fix/6050-do-not-reopen-connection
branch
from
64c1268
to
67cb647
Compare
|
fixed a related failing cypress test and now the REUSE compliance test is failing due to some css files. Not sure what to make of that. update: related to a pr that commits the css since yesterday. Julius is looking into it. |
|
/backport to stable29 |
|
/backport to stable28 |
|
cypress failures and compliance check are unrelated. |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/6054/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 67cb6478
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6054/stable29Error: Failed to push branch backport/6054/stable29: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable29 |
📝 Summary
Do not attempt to create a new connection
if there already is one and it is not closed.
If no messages are received for 30 seconds
yjs will open a new websocket.
Since we do not close the connection anymore from the websocket polyfill we also do not need to open it.
If the network connection has gone down
creating a new connection will fail anyway.
Once it comes back we will know if the session is still valid. Then we can either continue using it or reconnect.
This is part of #6050.
🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)