Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): Add data attribute to search decoration #6123

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Jul 25, 2024

This allows to get the element and scroll it into view, e.g. by Collectives.

This allows to get the element and scroll it into view, e.g. by
Collectives.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- added this to the Nextcloud 30 milestone Jul 25, 2024
@mejo- mejo- requested a review from elzody July 25, 2024 15:54
@mejo- mejo- self-assigned this Jul 25, 2024
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was wondering how to best achieve this, this seems like a good solution

@mejo- mejo- merged commit 462fcb6 into main Jul 25, 2024
32 checks passed
@mejo- mejo- deleted the fix/search_decoration_data_attr branch July 25, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants