-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate to files:node:updated #6427
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@luka-nextcloud what's the background for this change? Does it fix anything? Is it a technical dept thing? |
Sorry for not mentioning. This is a technical debt, I've added the issue on the description. |
Thanks for the additional context @luka-nextcloud. Do you know what the emitted event is supposed to do? I.e. is there a reproducer of how to test whether this works? |
@mejo- The emitted event is supposed to notify the other apps that a file was updated. Install text app and notes app (with this PR nextcloud/notes#1377) then open notes app to edit a note. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment
id: this.fileId, | ||
source: generateRemoteUrl(`dav/files/${user.uid}${this.relativePath}`), | ||
mtime: new Date(), | ||
mime: 'text/markdown', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text app might also handle other mime types, so we should take the one that the viewer passes along to us
📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)