Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Increase line width to 80 characters #6520

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Oct 11, 2024

📝 Summary

After discussion with designers we wanted to slightly increase the line width of text documents. This is basically the same width as talk uses now for messages which is 80 character width.

Browser support for the ch unit seems sufficient: https://caniuse.com/ch-unit

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot 2024-10-11 at 09 11 43 Screenshot 2024-10-11 at 09 11 56

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr juliusknorr added enhancement New feature or request design Experience, interaction, interface, … 3. to review labels Oct 11, 2024
@marcoambrosini
Copy link
Member

Hmm I think talk has already slightly decreased that, cc @Antreesy

@juliusknorr
Copy link
Member Author

Talks seems to be using https://github.com/nextcloud/spreed/blob/81c8bfca584c3cbb1d8aa4a716a2f19148bb7059/src/assets/variables.scss#L13 (which ends up at 750px with 15px font size), 80ch end up being 734px in text

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sgtm then!

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@juliusknorr juliusknorr merged commit 93a588d into main Oct 11, 2024
61 checks passed
@juliusknorr juliusknorr deleted the feat/increase-line-width branch October 11, 2024 07:53
@Antreesy
Copy link

Antreesy commented Oct 11, 2024

Just a note to consider: width may vary a bit depending on a font. so for OpenDyslexic 80ch is ~780px, for default on Win11 ~650px

@bekuno
Copy link

bekuno commented Nov 6, 2024

I propose to backport this small change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review design Experience, interaction, interface, … enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants