Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] Fix some JS console errors #6599

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Nov 5, 2024

Backport of #6597

@backportbot backportbot bot added bug Something isn't working 3. to review labels Nov 5, 2024
@backportbot backportbot bot added this to the Nextcloud 29.0.9 milestone Nov 5, 2024
@mejo- mejo- marked this pull request as ready for review November 5, 2024 09:27
@Altahrim Altahrim mentioned this pull request Nov 5, 2024
6 tasks
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing cypress test gets fixed by #6601

@Altahrim Altahrim mentioned this pull request Nov 7, 2024
7 tasks
The property `isEmbedded` only gets provided in `ViewerComponent.vue`.
When the editor gets created though other means, e.g. via editor API
(`editor.js`), `isEmbedded` is not provided and thus produces an error:

> Injection "isEmbedded" not found

Signed-off-by: Jonas <jonas@freesources.org>
@juliusknorr juliusknorr merged commit a148751 into stable29 Nov 7, 2024
59 checks passed
@juliusknorr juliusknorr deleted the backport/6597/stable29 branch November 7, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants