Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove confusing paragraph button #968

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

azul
Copy link
Contributor

@azul azul commented Aug 12, 2020

The paragraph button was confusing for a number of reasons:

  • it only acts on headings

  • the symbol indicates a line break
    rather than the removal of formatting

  • there are other ways to turn headings back to normal text

  • all other formatting is removed
    by clicking the same button again

  • Resolves: consolidate header and paragraph buttons? #353

  • Target version: master

Summary

See #353 for the discussion leading to this pull request.

@azul azul force-pushed the cleanup-confusing-paragraph-button branch from a578c2a to 5c699cc Compare August 12, 2020 17:45
@jancborchardt
Copy link
Member

Sounds good! :)

As said in the chat too, this needs the heading action menu (the dropdown trigger) to be highlighted too when you selected a heading so you see what to open to deselect the formatting again.

fixes #353.

The paragraph button was confusing for a number of reasons:
 * it only acts on headings
 * the symbol indicates a line break
   rather than the removal of formatting
 * there are other ways to turn headings back to normal text
 * all other formatting is removed
   by clicking the same button again

Signed-off-by: Azul <azul@riseup.net>
@juliusknorr juliusknorr force-pushed the cleanup-confusing-paragraph-button branch from 0c46256 to d03c65a Compare August 13, 2020 05:58
@juliusknorr juliusknorr merged commit 36a3d6b into master Aug 13, 2020
@juliusknorr juliusknorr deleted the cleanup-confusing-paragraph-button branch August 13, 2020 06:04
@asaage
Copy link

asaage commented Aug 31, 2022

there are other ways to turn headings back to normal text

@azul how would i do that now?
I've copy&pasted text from an arbitary website and headings are carried over as such.
I really can't find a way to turn them into normal text.

@susnux
Copy link
Contributor

susnux commented Aug 31, 2022

@asaage

I really can't find a way to turn them into normal text.

Just select the heading and click on the heading button again (e.g. click: heading 1 will make the text a heading of level 1, clicking the button again makes it normal text again):
Create heading and revert to normal text again

@jancborchardt
Copy link
Member

@asaage @susnux in a design review we also found that it’s confusing how to go back to normal formatting. We will add back a "Body text" entry in that menu, see #2836

Add a separate item in the heading menu "Body text" as the first item (but still only show dot indicator when any heading level is selected)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consolidate header and paragraph buttons?
5 participants