Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IDeactivatableByAdmin interface #374

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Implement IDeactivatableByAdmin interface #374

merged 1 commit into from
Jan 21, 2025

Conversation

tcitworld
Copy link
Member

So that the provider can simply be deactivated through CLI.

@tcitworld
feat: implement IDeactivatableByAdmin interface
c2a9ea7 
so that the provider can be deactivated by admin

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld added enhancement New feature or request 3. to review php Pull requests that update Php code labels Jan 6, 2025
ChristophWurst
ChristophWurst requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tcitworld!

Looks very nice!

appinfo/info.xml Outdated Show resolved Hide resolved
@tcitworld tcitworld force-pushed the implement-IDeactivatableByAdmin branch from 00b6d2b to c2a9ea7 Compare January 7, 2025 07:49
@github-actions GitHub Actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

ChristophWurst
ChristophWurst approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Apologies for the delay

@ChristophWurst ChristophWurst merged commit 6e5ba6f into main Jan 21, 2025
35 checks passed
@ChristophWurst ChristophWurst deleted the implement-IDeactivatableByAdmin branch January 21, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner

Assignees
No one assigned
Labels
3. to review enhancement New feature or request feedback-requested php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcitworld @ChristophWurst