Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update max version #320

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Update max version #320

merged 2 commits into from
Jan 23, 2020

Conversation

piti-diablotin
Copy link
Contributor

Signed-off-by: Jordan Bieder jordan.bieder@uliege.be

Update max version
e74182e 
Signed-off-by: Jordan Bieder <jordan.bieder@uliege.be>
@piti-diablotin piti-diablotin mentioned this pull request Jan 23, 2020
Merged
ChristophWurst
ChristophWurst approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change

twofactor_gateway/.travis.yml

Lines 72 to 76 in b3c9818

- php: 7.3
env: "DB=sqlite SERVER_BRANCH=stable16"
- php: 7.3
env: "DB=sqlite SERVER_BRANCH=stable17"
- php: 7.3
so that there is also an entry for stable18 :)

Add CI test for stable18+php7.3
33b8ba3 
Signed-off-by: Jordan Bieder <jordan.bieder@uliege.be>
@piti-diablotin
Copy link
Contributor Author

That should be it.
Thanks

@ChristophWurst ChristophWurst merged commit ecd2daa into nextcloud:master Jan 23, 2020
@ChristophWurst
Copy link
Member

Thanks!

@piti-diablotin piti-diablotin deleted the version branch January 24, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees
No one assigned
Labels
2. developing enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piti-diablotin @ChristophWurst