Fix provider state population to the server registry #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration test fails due to a bug that I'm about to fix (which I've actually done this refactoring for). |
ChristophWurst
changed the title
|
Obviously, CI fails now because the server part is missing. Let me quickly change the branch to test this temporarily … |
1 task
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
refactor/state-change-events
branch
from
4ecc594 to
17900cf
Compare
ChristophWurst
added a commit
to nextcloud/server
that referenced
this pull request
Jul 31, 2018
Starting with Nextcloud 14, the server knows the enabled/disabled state of 2fa providers. While it will query that information if it's unknown (on first use), it won't notice any changes. Thus, providers have to propagate that information themselves. Ref nextcloud/twofactor_totp#263 Ref nextcloud/twofactor_u2f#210 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added a commit
to nextcloud/server
that referenced
this pull request
Jul 31, 2018
Starting with Nextcloud 14, the server knows the enabled/disabled state of 2fa providers. While it will query that information if it's unknown (on first use), it won't notice any changes. Thus, providers have to propagate that information themselves. Ref nextcloud/twofactor_totp#263 Ref nextcloud/twofactor_u2f#210 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added a commit
to nextcloud/server
that referenced
this pull request
Jul 31, 2018
Starting with Nextcloud 14, the server knows the enabled/disabled state of 2fa providers. While it will query that information if it's unknown (on first use), it won't notice any changes. Thus, providers have to propagate that information themselves. Ref nextcloud/twofactor_totp#263 Ref nextcloud/twofactor_u2f#210 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
|
Thanks for your review 🕺 |
ChristophWurst
added a commit
to nextcloud/server
that referenced
this pull request
Aug 1, 2018
Starting with Nextcloud 14, the server knows the enabled/disabled state of 2fa providers. While it will query that information if it's unknown (on first use), it won't notice any changes. Thus, providers have to propagate that information themselves. Ref nextcloud/twofactor_totp#263 Ref nextcloud/twofactor_u2f#210 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
weeman1337
pushed a commit
to nextcloud/server
that referenced
this pull request
Aug 9, 2018
Starting with Nextcloud 14, the server knows the enabled/disabled state of 2fa providers. While it will query that information if it's unknown (on first use), it won't notice any changes. Thus, providers have to propagate that information themselves. Ref nextcloud/twofactor_totp#263 Ref nextcloud/twofactor_u2f#210 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for https://github.com/orgs/nextcloud/projects/4#card-10826964
This PR consists of two parts. First, a little refactoring to decouple some logic from the provider to decouple it from the necessary action on enabled/disabled state change via the server event system. Second, it adds a new state change listener that populates the state to the server's provider registry.
@rullzer please have a look :)