feat!: drop support for php 8.0 and nextcloud <= 29 #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
changed the title
|
Oh god, what have we done?! Tests fail because the already updated version of the webauthn dependency from server is loaded. So we need to drop PHP, update the dependency, fix deprecations and fix tests all at the same time. |
st3iny
force-pushed
the
feat/drop-php-8.0
branch
from
fe7116b
to
c75d353
Compare
st3iny
added
2. developing
st3iny
force-pushed
the
feat/drop-php-8.0
branch
from
8e16364
to
4f1cca9
Compare
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
feat/drop-php-8.0
branch
3 times, most recently
from
339a6a7
to
f3d6509
Compare
st3iny
added
3. to review
st3iny
force-pushed
the
feat/drop-php-8.0
branch
from
6b4e2ee
to
4eb3627
Compare
Adapt WebAuthn code in the backend. Replace custom (non-compliant) WebAuthn code in the frontend with @simplewebauthn/browser analogous to the changes in the server repository. Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
feat/drop-php-8.0
branch
from
4eb3627
to
18f7f50
Compare
st3iny
commented
May 3, 2024
There was a problem hiding this comment.
Things I tested
U2F migrator
- Set up a fresh Nc 23 instance.
- Install (deprecated) twfactor_u2f on Nc 23.
- Switch to a Nc master instance.
- Copy U2F registration table to my Nc master instance.
- Import real U2F data provided by Christoph.
- Run the migrator
- ✅ No errors and entries were migrated.
DB migrations
- Set up a fresh Nc 23 instance.
- Install the most recent version of twofactor_webauthn before we took over: https://github.com/nextcloud/twofactor_webauthn/releases/tag/v0.2.15
- Enable the app and add 2 keys.
- Switch to a Nc master instance.
- Install this branch and run all migrations.
- Delete all twofactor_webauthn migrations from the DB and remove the registration table.
- Import all twofactor_webauthn migrations and the registration table from the Nc 23 instance.
- Run all migrations on the master instance:
occ migrations:migrate twofactor_webauthn - ✅ All imported registrations from the Nc 23 instance were migrated without errors.
- ✅ Logging in with the imported devices still works.
Summary
The switch from Ramsey\Uuid\Uuid to Symfony\Component\Uid\Uuid did not break anything despite having to modify old database migrations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #574 and #573
Fix #573
This has to be done because we updated
web-auth/webauthn-libin server and we have to update it here too. It only supports PHP >= 8.1.Ref nextcloud/server#44761