Refactor recursiveDelete

[stjosh]

The recursiveDelete method causes problems in certain environments with the RecursiveDirectoryIterator not iterating through all elements of a tree when deleting nodes while iterating. See nextcloud/server#2737 for a more detailed discussion of the issue.

This is solved by first completing the iteration and only then deleting all elements (first the files, then the directories).

[MorrisJobke]

Could you apply the very same changes to the lib/Updater.php -

updater/lib/Updater.php

Lines 675 to 678 in 8b3d7d0

	foreach ($iterator as $fileInfo) {
	$action = $fileInfo->isDir() ? 'rmdir' : 'unlink';
	$action($fileInfo->getRealPath());
	}

This is also check in the integration tests and they will then succeed, if the changes are the very same.

Beside that the change looks good. 👍

Thanks

[stjosh]

Changes also applied to lib/Updater.php. Hope that makes it work. :)

[caco3]

What is the reason this pull request got stuck?
The CI-Link https://drone.nextcloud.com/nextcloud/updater/103 only shows "page not found", then redirects to an almost empty overview page...

[stjosh]

Ok, sending a dummy commit triggered the build pipeline again - the tests still failing (php55-cli, signed-off-check) look like stuff I can't do much about, right? @MorrisJobke: Another review and merging would be highly appreciated - updating from 12.0.1 to 12.0.2 was a pain again... :-/

[MorrisJobke]

the tests still failing (php55-cli, signed-off-check)

A rebase helps here.

What is the reason this pull request got stuck?

I had I open but then forgot to answer here, that a rebase would help to get this in. Let me do this and open a separate PR for this and get it merged.

[MorrisJobke]

I rebased this and squashed all commits into one. Let's see what CI says to it: #132

[stjosh]

Ah I see - rebasing would have done the trick. Sorry for not noticing that. Anyway, #132 seems to make CI happy, so I'll close this one. Thanks for your help @MorrisJobke

[MorrisJobke]

Thanks for your help @MorrisJobke

Thanks for your contribution 👍