Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(updater): Add instructions to extra files found error #568

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix(updater): Add instructions to extra files found error #568

merged 1 commit into from
Jun 4, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented May 30, 2024 •
edited
Loading

Add a hint about what to do about to try to improve the user experience a bit and cut down on forum FAQs (and occasional bug reports).

@joshtrichards joshtrichards force-pushed the jtr-fix-extra-files-instructions branch from ecd56e5 to 9861076 Compare May 30, 2024 21:16
@joshtrichards joshtrichards marked this pull request as ready for review May 30, 2024 21:20
@joshtrichards joshtrichards added this to the Nextcloud 30 milestone May 30, 2024
@joshtrichards joshtrichards force-pushed the jtr-fix-extra-files-instructions branch 2 times, most recently from 3a3a194 to d1ccbe9 Compare June 3, 2024 15:04
@joshtrichards
fix(updater): Add instructions to extra files found error
8d2db89 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
@joshtrichards joshtrichards force-pushed the jtr-fix-extra-files-instructions branch from d1ccbe9 to 8d2db89 Compare June 3, 2024 15:07
@joshtrichards
Copy link
Member Author

Rebased and updated updater.phar again within PR again due to recently updated master to fix the conflict. Can be merged at-will after tests complete again.

@come-nc come-nc merged commit 3b634b9 into master Jun 4, 2024
23 checks passed
@come-nc come-nc deleted the jtr-fix-extra-files-instructions branch June 4, 2024 06:44
@github-actions GitHub Actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@come-nc come-nc come-nc approved these changes

Assignees
No one assigned
Labels
4. to release enhancement feature: expected files Step 1 feedback-requested UX🙂
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
3 participants
@joshtrichards @kesselb @come-nc