fix(Groups): take over members during migration #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
force-pushed
the
fix/862/migrate-members-also
branch
2 times, most recently
from
53effdd to
7762d3b
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/862/migrate-members-also
branch
from
7762d3b to
6063847
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/862/migrate-members-also
branch
from
dba2f40 to
e2604db
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
…mbers Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/862/migrate-members-also
branch
from
541cfdd to
69e423a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
blizzz
force-pushed
the
fix/862/migrate-members-also
branch
2 times, most recently
from
4de43a1 to
f5513a5
Compare
blizzz
commented
Jul 17, 2024
Comment on lines
+285
to
+289
| And I "disable" the app "user_saml" | ||
| And the local group "Astrophysics" is created | ||
| And I hack "student2" into existence | ||
| And the user "student2" is added to the group "Astrophysics" | ||
| And I "enable" the app "user_saml" |
There was a problem hiding this comment.
This is plain awful, but I did not come up with any other way to resemble this situation. Easier would be issuing direct SQL queries, however this would be written again and support all DB flavours, and detect what is running on which port.
aka "occ saml:group-migration:copy-incomplete-members" Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/862/migrate-members-also
branch
from
f5513a5 to
244abb4
Compare
juliusknorr
approved these changes
Jul 18, 2024
| $this->groupMigration->cleanUpOldGroupUsers($gid); | ||
| } catch (Exception $e) { | ||
| $this->logger->warning('Error while cleaning up group members in (oc_)group_user of group (gid) {gid}', [ | ||
| 'app' => 'user_saml', |
There was a problem hiding this comment.
Isn't the app already set when getting the LoggerInterface through DI?
There was a problem hiding this comment.
Isn't the app already set when getting the LoggerInterface through DI?
I am never sure of that 🙈 Sometimes you see logs without an app set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #862
maybe add an occ command to see pending migrationshave a repair step insteadAlso contains a drive-by fix. I noticed that the list of groups is set newly on every repair step run. Commit 541cfdd fixes this.
failing test proof