Always use the main background for the default theme #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
/backport to stable24 |
backportbot-nextcloud
bot
added
the
backport-request
skjnldsv
approved these changes
Jul 6, 2022
|
Do we still need the theme override by view providers then? |
juliusknorr
commented
Jul 6, 2022
| body.theme--light & { | ||
| background-color: rgba(255, 255, 255, .92) !important; | ||
| } | ||
| background-color: var(--color-main-background) !important; |
There was a problem hiding this comment.
Transparency is removed intentional as per design review in nextcloud/text#2211 for text
Not sure I get the question fully, but setting the background color here is still necessary as for text (with the viewer theme--default) we need to override it as with the regular viewer it is always black |
luka-nextcloud
approved these changes
Jul 6, 2022
1 task
backportbot-nextcloud
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nextcloud/text#2374 as with the new accesibility options the old class was not matching anymore and we can always use the main background color in case of the "default" viewer theme which adapts the viewer UI to use the main background.